Skip to content

Fix pipeline stacktrace syntax error on CI. #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georg-schwarz merged 2 commits into from
May 25, 2021
Merged

Fix pipeline stacktrace syntax error on CI. #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5927bb0
Pipeline: Additional information for stack trace error messages
lunedis May 25, 2021
5be346c
Pipeline: Disable source maps to enable vm2 syntax error parsing
lunedis May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pipeline/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "dist/index.js",
"scripts": {
"start": "npm run transpile && npm run start:transpiled",
"start:transpiled": "node --enable-source-maps dist/index.js",
"start:transpiled": "node dist/index.js",
"transpile": "tsc",
"lint": "eslint src --fix",
"lint-ci": "eslint src --max-warnings=0",
Expand Down
4 changes: 2 additions & 2 deletions pipeline/src/pipeline-execution/sandbox/vm2StacktraceParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import JobError from './jobError'
export function parseStacktraceLine (line: string): [string, string, number, number] {
const match = line.match(/^ +at (.+) \((.+):(\d+):(\d+)\)/)
if (match === null) {
throw new Error('Unexpected stacktrace line format')
throw new Error(`Unexpected stacktrace line format: ${line}`)
}
const [, functionName, fileName, lineNumber, position] = match
return [functionName, fileName, parseInt(lineNumber), parseInt(position)]
Expand All @@ -24,7 +24,7 @@ export function parseStacktraceLine (line: string): [string, string, number, num
function parseSyntaxErrorHeader (header: string): [string, number] {
const match = header.match(/^(.+):(\d+)/)
if (match === null) {
throw new Error('Unexpected stacktrace format')
throw new Error(`Unexpected stacktrace format: ${header}`)
}
const [, fileName, lineNumber] = match
return [fileName, parseInt(lineNumber)]
Expand Down