fix: use ring crypto backend for rustls cross-compilation#14
Merged
Conversation
Switch from aws-lc-rs to ring as the crypto backend for rustls. aws-lc-rs requires complex cross-compilation setup (ARM assembler, stdatomic.h) that fails on GitHub Actions for aarch64-linux builds. ring is more portable and works out of the box for cross-compilation. Generated with AI Co-Authored-By: AI <ai@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch from
aws-lc-rstoringas the crypto backend for rustls.Problem
The
aws-lc-rscrate fails to build when cross-compiling foraarch64-unknown-linux-gnuon GitHub Actions:This happens because aws-lc-rs requires specific cross-compilation tools that aren't available in the CI environment.
Solution
Use
ringinstead ofaws-lc-rsby setting:ringis more portable and works out of the box for cross-compilation.Test Plan