Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the websocket is broken gracefully reload the site. #354

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

johnrtipton
Copy link

When the websocket is broken, the site currently displays an alert dialog asking the user to reload the page.

This patch gracefully tries to reload the site, backing off to 1 minute per retry.

@elimintz
Copy link
Collaborator

Thank you for this, looks good. Could you please explain why you also removed lines 76 to 78 in main.html?

@knoxvilledatabase
Copy link

When I put lines 76 to 78 back, the code gets stuck in a loop.

@johnrtipton
Copy link
Author

johnrtipton commented Feb 20, 2022

Thank you for this, looks good. Could you please explain why you also removed lines 76 to 78 in main.html?

Originally, the way I approached it I needed ws_url so I rewrote that a bit. Turns out I didn't need it, but I thought it was a little more concise and left it in the PR. I can remove it if you want.

@WolfgangFahl WolfgangFahl added the enhancement New feature or request label Aug 20, 2022
@WolfgangFahl
Copy link
Collaborator

should this go into 0.0.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants