Upgrade schema-utils, and handle single quotes in large JSON files #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, thank you for this loader!
This PR upgrades schema-utils, and updates the breaking change. https://github.com/webpack/schema-utils/releases/tag/v3.0.0.
Additionally, updated the test to be more strict about errors. In 50f3270, I added a use case with single quotes in
file-big.json, but the test still passed w/o changes. On errors, the webpacksourcewill start withthrow new Error, so the test was updated accordingly to detect any errors.In 8768142, the source is updated to handle this use-case. Updated test will pass.