feat(icons): use virtual text if possible#255
Merged
Conversation
brianhuster
force-pushed
the
master
branch
2 times, most recently
from
fc6b544 to
b9f240c
Compare
Contributor
Author
|
@justinmk Icon providers like mini.icons also returns highlight group for icon. Also, both |
justinmk
approved these changes
Feb 6, 2025
justinmk
left a comment
justinmk
left a comment
Owner
There was a problem hiding this comment.
Nicely done! I'll go ahead and merge this since it's low-risk.
justinmk
reviewed
Feb 6, 2025
| return | ||
| endif | ||
| highlight clear Conceal | ||
| let l:feat = has('nvim-0.8') ? 'extmark' : ((v:version >= 901 && has('textprop'))? 'textprop': 'conceal') |
Owner
There was a problem hiding this comment.
Should probably be a script-level var.
Owner
Ok. |
brianhuster
added a commit
to brianhuster/vim-dirvish
that referenced
this pull request
Feb 6, 2025
feat(icons): use virtual text if possible justinmk#255
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #145, #253
Screenshot of vim-dirvish with Nerdfont icon
Regarding #253, I don't see the bug when using virtual text (both extmark and textprop) instead of conceal for icons, so it's possibly a bug with icons. That's why I think PR can also close that issue