Merge pull request #12

stylistic improvements
justin-hackin · Mar 19, 2023 · 01dedb9 · 01dedb9 · vercel · Mar 19, 2023
2 parents d8d739b + 98a20b8
commit 01dedb9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/src/components/Articles/ProfessionalItem.tsx b/src/components/Articles/ProfessionalItem.tsx
@@ -12,7 +12,7 @@ const ProfessionalItem: React.FC<CMSProfessionalExperience> = ({
   return (
     <article className="border-t-2 border-neutral-light-6 py-6 first-of-type:border-none last-of-type:pb-0 dark:border-neutral-dark-2">
       <Heading level={3}>
-        <span className="rounded-md bg-neutral-light-12 px-2 text-neutral-light-1 dark:bg-neutral-dark-12 dark:text-neutral-dark-1">
+        <span className="text-neutral-dark-1 underline underline-offset-2 dark:text-neutral-light-1">
           {attributes.title}
         </span>
         <span> at {attributes.organization}</span>

diff --git a/src/components/PDF/PDF.tsx b/src/components/PDF/PDF.tsx
@@ -169,12 +169,11 @@ const styles = StyleSheet.create({
     fontSize: fontSizes.xxs,
     fontStyle: 'italic',
   },
-  professionalTitle: {
-    backgroundColor: neutralColor[12],
-    borderRadius: '3px',
-    color: neutralColor[1],
-    fontWeight: 700,
-    paddingHorizontal: spacers[1],
+  experienceSubtitle: {
+    fontWeight: 'bold',
+  },
+  experienceSubtitleRole: {
+    textDecoration: 'underline',
   },
   bold: { fontWeight: 700 },
   flexColumn: { display: 'flex', flexDirection: 'column' },
@@ -290,16 +289,19 @@ const PDF: React.FC<CMSData> = (props) => {
               <Text>Professional Experience</Text>
             </View>
             {professional.map((professionalExperience) => (
-              <View key={professionalExperience.slug}>
+              <View
+                style={styles.experienceSubtitle}
+                key={professionalExperience.slug}
+              >
                 <View
                   style={styles.itemHeading}
                   minPresenceAhead={minPresenceAhead}
                 >
-                  <Text style={styles.professionalTitle}>
+                  <Text style={styles.experienceSubtitleRole}>
                     {professionalExperience.attributes.title}
                   </Text>
                   <Text>
-                    &nbsp;at {professionalExperience.attributes.organization}
+                    at {professionalExperience.attributes.organization}
                   </Text>
                 </View>
                 <View style={styles.itemSubheadingRow}>