-
Notifications
You must be signed in to change notification settings - Fork 1
[2025-11-04] [LIVE] [General] Assorted Improvements #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Before, it was using the WebKit hack, whether it was one or two images, and it’s really only needed for two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixes so far look good! But I still have a few comments:
-
Since you upgraded node to version 20, I strongly suggest to regenerate the lock file so it has the correct structure that's recommended for the version.
rm -rf node_modules/ package-lock.json && npm install -
When I ran
npm testI got the following error:Uncaught exception in test/browser.js test/browser.js:9 8: const virtualConsole = new VirtualConsole(); 9: virtualConsole.sendTo(console); 10: TypeError: virtualConsole.sendTo is not a function › Object.<anonymous> (test/browser.js:9:16) ✘ test/browser.js exited with a non-zero exit code: 1 ✔ server › should expose lazyframe() ─ 1 test passed 1 uncaught exceptionSo I checked the jsdom documentation and it seems that the correct method is
forwardTo(). But after I replace it, I got even more errors. Not sure if the tests worked before all the updates. Can you take a look? -
After I ran
npm run buildthedist/lazyframe.cssfile was modified, can you please commit the change?
Digznav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just please resolve the merge conflicts!
Fixes & Improvements
Refactoring & Performance (New)
XMLHttpRequestwith modernfetchAPI andasync/await.IntersectionObserverusing aMap(O(1)) instead of array traversal (O(n)).Features & Options
TypeScript Migration
Other Updates
Testing
browser.jstests.fetchandIntersectionObserver.Maintenance
Reference Links
For more details, you can check: https://app.clickup.com/t/86b44hm62