Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pie-monorepo): DSW-1047 update eslint pkg and eslintignore #673

Merged
merged 5 commits into from
Aug 2, 2023

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Aug 2, 2023

Describe your changes (can list changeset entries if preferable)

  • Updated @typescript-eslint/parser to latest
  • Added .eslintignore

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • If it is a PIE Docs change, I have reviewed the Docs site preview
  • If it is a component change, I have reviewed the Storybook preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • If it is a PIE Docs change, I have reviewed the PR preview
  • If there are visual test updates, I have reviewed them

chore(eslint-config-pie): DSW-1047 updated typescript eslint package
@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: d70ee07

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-673 August 2, 2023 12:09 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-673 August 2, 2023 12:09 Inactive
@JoshuaNg2332 JoshuaNg2332 marked this pull request as ready for review August 2, 2023 12:12
@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners August 2, 2023 12:12
@github-actions github-actions bot temporarily deployed to pie-storybook-pr-673 August 2, 2023 12:20 Inactive
@github-actions github-actions bot temporarily deployed to pie-docs-pr-673 August 2, 2023 12:20 Inactive
Copy link
Contributor

@siggerzz siggerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Myself and Josh have already discussed work that needs to come off the back of this, but I'm keen to not increase the scope of this work, and cover it as part of separate tickets 👍🏼

@github-actions github-actions bot temporarily deployed to pie-storybook-pr-673 August 2, 2023 15:05 Inactive
@JoshuaNg2332 JoshuaNg2332 merged commit 90258cf into main Aug 2, 2023
26 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the dsw-1047-eslint-ignore branch August 2, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants