Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify benchmarks #869

Merged

Conversation

martincostello
Copy link
Member

- Remove need for custom configuration now that `UseArtifactsOutput` is supported.
- Use collection expression.
- Simplify class declaration.
@martincostello martincostello added enhancement A change that enhances existing functionality or documentation. .NET Pull requests that update .net code labels Aug 7, 2024
@martincostello martincostello requested a review from a team as a code owner August 7, 2024 07:16
@martincostello martincostello enabled auto-merge (rebase) August 7, 2024 07:16
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.30%. Comparing base (bb85ee9) to head (456bde4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #869   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          15       15           
  Lines         868      868           
  Branches      198      198           
=======================================
  Hits          862      862           
  Misses          4        4           
  Partials        2        2           
Flag Coverage Δ
linux 99.30% <ø> (ø)
macos 99.30% <ø> (ø)
windows 99.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 6c59e4f into justeattakeaway:main Aug 7, 2024
13 checks passed
@martincostello martincostello deleted the simplify-benchmarks branch August 7, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that enhances existing functionality or documentation. .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant