Handler instance per request from IHandlerResolver #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using IHandlerResolver, resolve the handler per request, not once upfront This needs tests and docs and maybe breaking changes But a start is going back to old behaviour as per justeattakeaway/JustSaying#206 (comment)
|
@AnthonySteele This makes sense, shall I merge and we do a minor release? |
|
Yes, that's a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
IHandlerResolver, resolve the handler per request, not once upfrontThis needs tests (this behaviour was changed without tests breaking, so it's not well defined) and docs and maybe breaking changes as the other overload of
WithMessageHandlerworks differently.But a quick, non-breaking start is going back to old behaviour (it was like this earlier this year: https://github.com/justeat/JustSaying/blob/3aee35f286c247ba2739f6ba57ec770a13dc7656/JustSaying/JustSayingFluently.cs#L247) as per this discussion #206 (comment)