Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend message attribute handling #1557

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Extend message attribute handling #1557

merged 1 commit into from
Nov 6, 2024

Conversation

martincostello
Copy link
Member

Handle message attributes of type Number or with a custom suffix label.

Resolves #1556.

Handle message attributes of type `Number` or with a custom suffix label.
Resolves #1556.
@martincostello martincostello requested a review from a team as a code owner November 6, 2024 15:06
@martincostello martincostello added this to the v8.0.0 milestone Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (56b8877) to head (dcbbec2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...aging/MessageSerialization/NewtonsoftSerializer.cs 84.61% 1 Missing and 1 partial ⚠️
...ing/MessageSerialization/MessageAttributeParser.cs 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1557      +/-   ##
==========================================
- Coverage   78.65%   78.36%   -0.29%     
==========================================
  Files         140      141       +1     
  Lines        3556     3550       -6     
  Branches      501      501              
==========================================
- Hits         2797     2782      -15     
- Misses        511      519       +8     
- Partials      248      249       +1     
Flag Coverage Δ
linux 78.36% <87.50%> (-0.29%) ⬇️
macos ?
windows 47.35% <87.50%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 9482817 into main Nov 6, 2024
13 of 14 checks passed
@martincostello martincostello deleted the gh-1556 branch November 6, 2024 19:54
@martincostello martincostello modified the milestones: v8.0.0, v7.2.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.FormatException when MessageAttributes contains type number
2 participants