Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the xunit group with 1 update #1268

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Bump the xunit group with 1 update #1268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50998e4
Bump the xunit group with 1 update
dependabot[bot] Nov 1, 2023
3dbd7b7
Fix tests
martincostello Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
<PackageVersion Include="SerilogTimings" Version="3.0.1" />
<PackageVersion Include="Shouldly" Version="4.2.1" />
<PackageVersion Include="Swashbuckle.AspNetCore" Version="6.5.0" />
<PackageVersion Include="xunit" Version="2.5.3" />
<PackageVersion Include="xunit" Version="2.6.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.3" />
</ItemGroup>
</Project>
2 changes: 1 addition & 1 deletion tests/JustSaying.UnitTests/Messaging/Channels/ChannelsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public async Task Messages_Not_Dispatched_After_Cancellation()

cts.CancelAfter(_timeoutPeriod);

await Assert.ThrowsAnyAsync<OperationCanceledException>(async () => await runTask);
await Assert.ThrowsAnyAsync<OperationCanceledException>(() => runTask);

dispatchedBeforeCancelled.ShouldBeGreaterThan(0);
dispatchedAfterCancelled.ShouldBe(0);
Expand Down
6 changes: 3 additions & 3 deletions tests/JustSaying.UnitTests/Messaging/Channels/MultiplexerTests/MergingMultiplexerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ public void Cannot_Add_Invalid_Reader()
}

[Fact]
public void Cannot_Get_Messages_Before_Started()
public async Task Cannot_Get_Messages_Before_Started()
{
// Arrange
using var multiplexer = new MergingMultiplexer(10, _outputHelper.ToLogger<MergingMultiplexer>());

// Act and Assert
Assert.ThrowsAsync<InvalidOperationException>(async () => await ReadAllMessages(multiplexer));
await Assert.ThrowsAsync<InvalidOperationException>(() => ReadAllMessages(multiplexer));
}

[Fact]
Expand Down Expand Up @@ -119,4 +119,4 @@ private static async Task ReadAllMessages(IMultiplexer multiplexer)
{
}
}
}
}
8 changes: 4 additions & 4 deletions tests/JustSaying.UnitTests/Messaging/Policies/CanCreatePolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,17 @@ public async Task Can_Integrate_With_Polly_Policies_Async()
new PollyMiddleware<string, int>(pollyPolicy));

var calledCount = 0;
await Assert.ThrowsAsync<CustomException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<CustomException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
}, CancellationToken.None));
await Assert.ThrowsAsync<CustomException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<CustomException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
}, CancellationToken.None));
await Assert.ThrowsAsync<BrokenCircuitException>(async () => await policy.RunAsync("context", ct =>
await Assert.ThrowsAsync<BrokenCircuitException>(() => policy.RunAsync("context", ct =>
{
calledCount++;
throw new CustomException();
Expand All @@ -88,4 +88,4 @@ public CustomException()
{
}
}
}
}