Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub coverage summaries #1142

Conversation

martincostello
Copy link
Member

  • Add a code coverage summary to the Actions logs.
  • Use the MSBuild version of ReportGenerator.
  • Simplify PowerShell script.
  • Rename build script to lowercase.

- Add a code coverage summary to the Actions logs.
- Use the MSBuild version of ReportGenerator.
- Simplify PowerShell script.
- Rename build script to lowercase.
@martincostello martincostello added enhancement github_actions Pull requests that update GitHub Actions code labels Mar 10, 2023
Fix the path the coverage is output to.
MSBuild evaluation order meant it wasn't running if moved to the `.targets` file.
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1142 (3395c55) into main (844bdaf) will increase coverage by 32.62%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1142       +/-   ##
===========================================
+ Coverage   53.65%   86.27%   +32.62%     
===========================================
  Files         133      137        +4     
  Lines        3202     3308      +106     
===========================================
+ Hits         1718     2854     +1136     
+ Misses       1484      454     -1030     
Flag Coverage Δ
linux 86.27% <ø> (?)
macos 53.93% <ø> (?)
windows 53.93% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 61 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fix the executable bit being unset by rename.
@martincostello martincostello marked this pull request as ready for review March 10, 2023 16:33
@martincostello martincostello requested a review from a team as a code owner March 10, 2023 16:33
@martincostello martincostello enabled auto-merge (squash) March 10, 2023 16:33
@martincostello martincostello merged commit edf0dd5 into justeattakeaway:main Mar 10, 2023
@martincostello martincostello deleted the improve-github-coverage-output branch March 10, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants