Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1106 Add middleware examples #1137

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

adammorr
Copy link
Contributor

@adammorr adammorr commented Mar 1, 2023

#1106

Add an example console app to show how middlewares can be used, as well as calling out some default behaviours / pitfalls.

There's a bit of code overlap with the other example so might be able to consolidate or, leave as two separate things!

Heavily inspired by what George put together 🎆

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1137 (06fe382) into main (df1b1a2) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   86.27%   86.06%   -0.22%     
==========================================
  Files         137      137              
  Lines        3308     3308              
==========================================
- Hits         2854     2847       -7     
- Misses        454      461       +7     
Flag Coverage Δ
linux 86.06% <ø> (-0.22%) ⬇️
macos 53.65% <ø> (-0.29%) ⬇️
windows 53.93% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ools/MessageHandling/Dispatch/MessageDispatcher.cs 85.45% <0.00%> (-12.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@adammorr adammorr marked this pull request as ready for review March 1, 2023 11:36
@adammorr adammorr requested a review from a team as a code owner March 1, 2023 11:36
@adammorr adammorr merged commit a75c75c into justeattakeaway:main Mar 1, 2023
@adammorr adammorr deleted the issue-1106 branch March 1, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants