Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package publishing #1123

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix package publishing #1123

merged 1 commit into from
Feb 1, 2023

Conversation

martincostello
Copy link
Member

We missed the org name for GitHub packages.

We missed the org name for GitHub packages.
@slang25
Copy link
Member

slang25 commented Feb 1, 2023

I saw a nuget url and ignored it, forgot we had the GH package feed 🤦

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Merging #1123 (b9e3593) into main (a375b71) will decrease coverage by 32.38%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #1123       +/-   ##
===========================================
- Coverage   86.30%   53.93%   -32.38%     
===========================================
  Files         137      133        -4     
  Lines        3308     3202      -106     
===========================================
- Hits         2855     1727     -1128     
- Misses        453     1475     +1022     
Flag Coverage Δ
linux ?
macos 53.93% <ø> (ø)
windows 53.93% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/JustSaying/Fluent/TopicAddressPublisher.cs 0.00% <0.00%> (-100.00%) ⬇️
...rc/JustSaying/Naming/NamingConventionExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...c/JustSaying/AwsTools/MessageHandling/SqsPolicy.cs 0.00% <0.00%> (-100.00%) ⬇️
.../JustSaying/Fluent/SqsWriteConfigurationBuilder.cs 0.00% <0.00%> (-100.00%) ⬇️
...ustSaying/Messaging/MessageHandling/ListHandler.cs 0.00% <0.00%> (-100.00%) ⬇️
...tSaying/Fluent/QueueAddressPublicationBuilder`1.cs 0.00% <0.00%> (-100.00%) ⬇️
...ing/AwsTools/QueueCreation/ServerSideEncryption.cs 0.00% <0.00%> (-100.00%) ⬇️
...ng/AwsTools/QueueCreation/SqsWriteConfiguration.cs 0.00% <0.00%> (-100.00%) ⬇️
.../Fluent/ServiceResolver/CompoundServiceResolver.cs 0.00% <0.00%> (-100.00%) ⬇️
...t/PublishConfig/DynamicPublicationConfiguration.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 52 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martincostello martincostello merged commit 0167120 into main Feb 1, 2023
@martincostello martincostello deleted the fix-package-feed-name branch February 1, 2023 13:54
@slang25 slang25 restored the fix-package-feed-name branch February 1, 2023 13:54
@slang25 slang25 deleted the fix-package-feed-name branch February 1, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants