Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
Address PR feedback from #1308.
  • Loading branch information
martincostello committed Feb 5, 2024
1 parent 0ff522d commit 6cdcfd5
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,4 @@ public IAmazonSQS GetSqsClient(RegionEndpoint region)
}
return sqs;
}

}
16 changes: 8 additions & 8 deletions src/JustSaying.Extensions.Aws/IServiceCollectionExtensions.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
using System.ComponentModel;
using Amazon.SimpleNotificationService;
using Amazon.SQS;
using JustSaying;
using JustSaying.AwsTools;
using JustSaying.Extensions.Aws;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection.Extensions;
using System.ComponentModel;

namespace Microsoft.Extensions.DependencyInjection;

Expand All @@ -16,7 +16,7 @@ namespace Microsoft.Extensions.DependencyInjection;
public static class IServiceCollectionExtensions
{
/// <summary>
/// Adds JustSaying services to the service collection.
/// Adds JustSaying services to the service collection using AWS configuration.
/// </summary>
/// <param name="services">The <see cref="IServiceCollection"/> to add JustSaying services to.</param>
/// <param name="configuration">The <see cref="IConfiguration"/> used to setup AWS configuration.</param>
Expand All @@ -25,7 +25,7 @@ public static class IServiceCollectionExtensions
/// The <see cref="IServiceCollection"/> specified by <paramref name="services"/>.
/// </returns>
/// <exception cref="ArgumentNullException">
/// <paramref name="services"/> is <see langword="null"/>.
/// <paramref name="services"/>, <paramref name="configuration"/> or <paramref name="builderConfig"/> is <see langword="null"/>.
/// </exception>
public static void AddJustSayingWithAwsConfig(this IServiceCollection services, IConfiguration configuration, Action<MessagingBusBuilder> builderConfig)
{
Expand All @@ -48,7 +48,7 @@ public static void AddJustSayingWithAwsConfig(this IServiceCollection services,
}

/// <summary>
/// Adds JustSaying services to the service collection.
/// Adds JustSaying services to the service collection using AWS configuration.
/// </summary>
/// <param name="services">The <see cref="IServiceCollection"/> to add JustSaying services to.</param>
/// <param name="configuration">The <see cref="IConfiguration"/> used to setup AWS configuration.</param>
Expand All @@ -57,21 +57,21 @@ public static void AddJustSayingWithAwsConfig(this IServiceCollection services,
/// The <see cref="IServiceCollection"/> specified by <paramref name="services"/>.
/// </returns>
/// <exception cref="ArgumentNullException">
/// <paramref name="services"/> is <see langword="null"/>.
/// <paramref name="services"/>, <paramref name="configuration"/> or <paramref name="builderConfig"/> is <see langword="null"/>.
/// </exception>
public static void AddJustSayingWithAwsConfig(this IServiceCollection services, IConfiguration configuration, Action<MessagingBusBuilder, IServiceProvider> builderConfig)
{
if(services is null)
if (services is null)
{
throw new ArgumentNullException(nameof(services));
}

if(configuration is null)
if (configuration is null)
{
throw new ArgumentNullException(nameof(configuration));
}

if(builderConfig is null)
if (builderConfig is null)
{
throw new ArgumentNullException(nameof(builderConfig));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<IsShipping>true</IsShipping>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Expand Down
Empty file.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions
static Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions.AddJustSayingWithAwsConfig(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.Extensions.Configuration.IConfiguration configuration, System.Action<JustSaying.MessagingBusBuilder, System.IServiceProvider> builderConfig) -> void
static Microsoft.Extensions.DependencyInjection.IServiceCollectionExtensions.AddJustSayingWithAwsConfig(this Microsoft.Extensions.DependencyInjection.IServiceCollection services, Microsoft.Extensions.Configuration.IConfiguration configuration, System.Action<JustSaying.MessagingBusBuilder> builderConfig) -> void

0 comments on commit 6cdcfd5

Please sign in to comment.