SQS error queues are not created when specifying a queue by name #38
Labels
Comments
Merged
tomhaigh
pushed a commit
that referenced
this issue
Feb 15, 2017
* Monitoring a named queue should also monitor the matching error queue #38 Start with a failing test * Refactoring - hoisted the call to queueSource.GetResourceNamesAsync so do it once per alerting group * Extract methods * This passes the test but is unnecessary when the queue names come from pattern matches anwyay * Failing test on similar queue name pattern * tests are passing code is complex .. also might be ugly? * pattern mismatch test and fix * Minor refactor * Test extra queue name It's different to pattern as it's not removed by pattern expansion * Rename these methods to show that they mutate state * Move logic into Queue class, easier to use elsewhere * Tom's Simpler way to do it - expand name to a regexp that matches {name} and {name}{errorSuffix} Same tests, still pass * Names and suffixes are to be taken literally in regexp
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is because the regular expression match is skipped for these.
Possible solution is to separately expand those into {Name} and {Name}-{ErrorSuffix} (where queues exist)
The text was updated successfully, but these errors were encountered: