replaced top and bottom shadow by background shadow 9patch#26
Open
meesec wants to merge 2 commits intojustasm:masterfrom
Open
replaced top and bottom shadow by background shadow 9patch#26meesec wants to merge 2 commits intojustasm:masterfrom
meesec wants to merge 2 commits intojustasm:masterfrom
Conversation
Owner
| */ | ||
| private final Drawable dragBottomShadowDrawable; | ||
| private final Drawable dragShadowDrawable; | ||
| private final int dragShadowHeight; |
Owner
There was a problem hiding this comment.
Rename this to dragShadowMargin or similar.
Author
|
updated. i checked on an ldpi emulator, seems to work fine with the xxhdpi 9patch. set alpha to 75 on the shadow. feel free to pick a different alpha. |
Owner
|
What did you use to generate the 9-patch? |
Author
|
A designer in my project build it a while ago. I assume sketch. |
|
thanks, I will check it as soon as I can |
|
How can I remove shadow when moving? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
suggested fix for recent discussion around drag shadow.