fix: insert() | delete() would calculate the new insert incorrectly

Refs helix-editor#386
justanotherdot · Jun 28, 2021 · ca98210 · ca98210
1 parent d4e1ec3
commit ca98210
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/helix-core/src/transaction.rs b/helix-core/src/transaction.rs
@@ -193,9 +193,10 @@ impl ChangeSet {
                             head_b = changes_b.next();
                         }
                         Ordering::Greater => {
+                            // TODO: cover this with a test
                             // figure out the byte index of the truncated string end
                             let (pos, _) = s.char_indices().nth(len - j).unwrap();
-                            s.pop_front(s.len() as u32 - pos as u32);
+                            s.pop_front(pos as u32);
                             head_a = Some(Insert(s));
                             head_b = changes_b.next();
                         }