-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General updates #5
Conversation
✅ Deploy Preview for just-the-docs-template ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@mattxwang I don't see how to request a review for this PR in the usual way… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries on the requesting review portion; this LGTM. Left one nit but we can address post-merge.
webrick (1.7.0) | ||
|
||
PLATFORMS | ||
x86_64-darwin-19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% sure we may need to also eventually add other platforms, but we can do that separately!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: 88e466d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mattxwang thanks for approving and merging this PR! I was expecting that you'd suggest some changes. Anyway, the template is something that we can easily update later, based on user feedback and experience.
When I next get a bit of spare time (hopefully this week) I'll try submitting a PR for the theme docs home page and README, referring to the template for details.
PR welcome for that as well! |
This PR aims to make the template easier to use for those new to Jekyll and the Just the Docs theme. The changes in this PR are merely my suggestions (based on my own lack of understanding of what terms like "deploy" really mean).
index.md
to give an overview of what the template can do.README.md
to focus on how to do it (preview)..gitignore
,_config.yml
, andGemfile
.When the template has been finalised, I'd like to add a reference to it on the theme home page.