fix(tui/ime): drop repeat events during composition #368
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | KeyCode::Home | ||
| | KeyCode::End | ||
| | KeyCode::Backspace | ||
| | KeyCode::Delete => {} | ||
| _ => continue, |
There was a problem hiding this comment.
On Windows we now drop every KeyEventKind::Repeat except for navigation/backspace/delete. That avoids IME duplicates, but it also disables normal key auto-repeat for letters and other character keys when a user holds a key down. Editors typically rely on repeated key events for fast text input, so this change regresses basic typing outside IME scenarios. Consider only filtering repeats while composition is active or restricting the filter to IME-generated sequences rather than all non-navigation repeats.
Useful? React with 👍 / 👎.
|
Preview Build rerun triggered after #364 merged; watching for green checks. |
|
Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks. |
|
@zemaj Thanks for hanging in there and keeping an eye on those reruns! The fresh preview finished successfully once we moved everything over to Rust 1.90, so the missing-component hiccups should be gone now. You can spin up the same build yourself anytime with: code preview toolchain-preview-buildOnce it launches, just watch the checks panel—everything should stay green. I’d love to hear if it’s behaving smoothly on your side or if anything still feels off. Thanks again for flagging this! |
|
Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870478936 |
zemaj
force-pushed
the
main
branch
2 times, most recently
from
804b5ad to
b7927a2
Compare
Summary
KeyEventKind::Repeatevents before they reach the composer so IME interim keys aren't insertedTesting
Fixes #277