feat: Explicit autowiring of crates #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A case for enabling autowiring by default: when people add new crates (e.g.: juspay/superposition#92) and don't necessarily remember to explicitly enable it for that new crate. OR Smart autowiring? Should crates with binaries be autowired by default? 
|
This was referenced Jul 13, 2024
On a multi-crate workspace, disable autowiring of crates by default. Let the user wire the individual crates manually. Otherwise, they will be forced to configure each crate to build in Nix separately (via specifying `buildInputs`) which is quite unnecessary if only a handful of crates need to be exposed in the flake.
Regardless of autoWire
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a multi-crate workspace, disable autowiring of crates by default, unless the crate has binaries. Otherwise, they will be forced to configure each library crate to build in Nix separately (via specifying
buildInputs) which is quite unnecessary if only a handful of crates need to be exposed in the flake.The user can toggle
autoWireon or off for individual crates. The packages are nevertheless exposed as options.outputs.packageregardless of autowiring for manual wiring?