Stop capturing Ctrl+B for inspector toggle - #821
Conversation
Hickey/Lowy AnalysisNo findings — analysis below. Hickey rationaleThe diff reuses the existing Actions: No actions. Lowy rationaleShortcut chord choice is activity volatility: external conflicts can change which physical chord invokes an action. This remains encapsulated in Actions: No actions. |
|
| Step | Status | Duration | Verification |
|---|---|---|---|
| sync | ✓ | 0s | git fetch ok; forge=github; noGit=false |
| research | ✓ | 1m 6s | Issue #820 maps to packages/client/src/input/actions.ts:208 toggleRightPanel mod+b; display surfaces derive from ACTIONS, tests press MOD_KEY+b in packages/tests/step_definitions/right_panel_steps.ts:7 |
| branch | ✓ | 5s | On feature branch fix-820-inspector-shortcut tracking origin/master |
| implement | ✓ | 1m 25s | Changed toggleRightPanel to Mod+Alt+B; updated e2e helper; focused keyboard unit test passes and asserts Ctrl+B is not captured |
| check | ✓ | 18s | just check exited 0; typecheck passed and biome lint reported warnings only |
| docs | ✓ | 4s | Docs checked: README and packages/surface/README have no stale Ctrl+B/Cmd+B inspector shortcut text; generated UI surfaces read ACTIONS |
| fmt | ✓ | 6s | just fmt exited 0; biome and nixpkgs-fmt made no changes |
| commit | ✓ | 10s | Committed 98b3a6d and pushed origin/fix-820-inspector-shortcut |
| hickey+lowy | ✓ | 2m 37s | Hickey and Lowy subagents completed; both reported no findings/actions |
| police | ✓ | 1m 5s | code-police all clear: rules/fact-check/elegance found no issues; no follow-up commits needed |
| test | ✓ | 35s | Unit: kolu-client keyboard.test.ts 22 passed; E2E: just test-quick features/right-panel.feature 13 scenarios/83 steps passed |
| create-pr | ✓ | 39s | Draft PR #821 created; title/body match scope; Hickey/Lowy analysis comment posted |
| ci | ✗ | 13m 27s | CI exhausted retries: full just ci passed all contexts except ci/e2e@aarch64-darwin; x86_64-linux e2e passed on retry; aarch64-darwin e2e failed after three retries in unrelated session/worktree scenarios with server Napi::Error/timeouts |
| Total | 23m 59s |
Slowest step: ci (13m 27s)
Optimization suggestions
- Re-run from
cionly after the Darwin e2e instability is fixed; CI took 13m 27s and was the only failed step. - Harden the Darwin e2e server crash path around
Napi::Error; the failures cascaded from session/worktree scenarios into reset RPC timeouts. - Keep shortcut behavior covered by focused unit tests like
keyboard.test.ts; they caught the Ctrl+B regression directly and ran much faster than full e2e.
Workflow failed at 2026-05-04T17:57:22Z.
`Ctrl+B` was released back to the terminal in #821, then reclaimed as the dock toggle shortcut when the dock shipped as canonical in #903. The unit test still asserted "does not capture Ctrl+B" — flip to assert it matches, since `toggleDock` carries `{key:"b", mod:true}` and `mod` resolves to `ctrlKey` on Linux/Windows.
Ctrl+B now reaches the terminal instead of toggling Kolu's inspector, avoiding the Claude Code shortcut conflict reported on Linux. The inspector remains keyboard-accessible through a slightly more explicit
Mod+Alt+Bchord, and all visible shortcut hints still derive from the central action registry.The change stays inside the existing shortcut system:
toggleRightPanelowns the new chord, the e2e helper presses that semantic shortcut, and the unit coverage now pins both sides of the regression: plainCtrl+Bis not captured, whileCtrl+Alt+Bstill toggles the inspector on Linux.Closes #820
Try it locally
Generated by
/doon Codex (modelgpt-5).