Skip to content

Stop capturing Ctrl+B for inspector toggle - #821

Merged
srid merged 1 commit into
masterfrom
fix-820-inspector-shortcut
May 4, 2026
Merged

Stop capturing Ctrl+B for inspector toggle#821
srid merged 1 commit into
masterfrom
fix-820-inspector-shortcut

Conversation

@srid

@srid srid commented May 4, 2026

Copy link
Copy Markdown
Member

Ctrl+B now reaches the terminal instead of toggling Kolu's inspector, avoiding the Claude Code shortcut conflict reported on Linux. The inspector remains keyboard-accessible through a slightly more explicit Mod+Alt+B chord, and all visible shortcut hints still derive from the central action registry.

The change stays inside the existing shortcut system: toggleRightPanel owns the new chord, the e2e helper presses that semantic shortcut, and the unit coverage now pins both sides of the regression: plain Ctrl+B is not captured, while Ctrl+Alt+B still toggles the inspector on Linux.

Closes #820

Try it locally

nix run github:juspay/kolu/fix-820-inspector-shortcut

Generated by /do on Codex (model gpt-5).

@srid

srid commented May 4, 2026

Copy link
Copy Markdown
Member Author

Hickey/Lowy Analysis

No findings — analysis below.

Hickey rationale

The diff reuses the existing Keybind shape, ACTIONS.toggleRightPanel, matchesAnyShortcut, and formatKeybind pipeline rather than introducing a parallel shortcut concept. The shortcut change is data-only at the action registry line, and the tests exercise the existing matching/formatting primitives. No new mutable state, lifecycle nesting, duplicated derivation, hand-rolled parsing, or structural coupling was found.

Actions: No actions.

Lowy rationale

Shortcut chord choice is activity volatility: external conflicts can change which physical chord invokes an action. This remains encapsulated in ACTIONS.toggleRightPanel.keybind, while runtime consumers and display surfaces continue deriving from ACTIONS. The e2e feature now names the user intent, while the step definition owns the physical keypress, keeping future shortcut churn out of the feature text.

Actions: No actions.

@srid srid mentioned this pull request May 4, 2026
@srid

srid commented May 4, 2026

Copy link
Copy Markdown
Member Author

/do results

Step Status Duration Verification
sync 0s git fetch ok; forge=github; noGit=false
research 1m 6s Issue #820 maps to packages/client/src/input/actions.ts:208 toggleRightPanel mod+b; display surfaces derive from ACTIONS, tests press MOD_KEY+b in packages/tests/step_definitions/right_panel_steps.ts:7
branch 5s On feature branch fix-820-inspector-shortcut tracking origin/master
implement 1m 25s Changed toggleRightPanel to Mod+Alt+B; updated e2e helper; focused keyboard unit test passes and asserts Ctrl+B is not captured
check 18s just check exited 0; typecheck passed and biome lint reported warnings only
docs 4s Docs checked: README and packages/surface/README have no stale Ctrl+B/Cmd+B inspector shortcut text; generated UI surfaces read ACTIONS
fmt 6s just fmt exited 0; biome and nixpkgs-fmt made no changes
commit 10s Committed 98b3a6d and pushed origin/fix-820-inspector-shortcut
hickey+lowy 2m 37s Hickey and Lowy subagents completed; both reported no findings/actions
police 1m 5s code-police all clear: rules/fact-check/elegance found no issues; no follow-up commits needed
test 35s Unit: kolu-client keyboard.test.ts 22 passed; E2E: just test-quick features/right-panel.feature 13 scenarios/83 steps passed
create-pr 39s Draft PR #821 created; title/body match scope; Hickey/Lowy analysis comment posted
ci 13m 27s CI exhausted retries: full just ci passed all contexts except ci/e2e@aarch64-darwin; x86_64-linux e2e passed on retry; aarch64-darwin e2e failed after three retries in unrelated session/worktree scenarios with server Napi::Error/timeouts
Total 23m 59s

Slowest step: ci (13m 27s)

Optimization suggestions

  • Re-run from ci only after the Darwin e2e instability is fixed; CI took 13m 27s and was the only failed step.
  • Harden the Darwin e2e server crash path around Napi::Error; the failures cascaded from session/worktree scenarios into reset RPC timeouts.
  • Keep shortcut behavior covered by focused unit tests like keyboard.test.ts; they caught the Ctrl+B regression directly and ran much faster than full e2e.

Workflow failed at 2026-05-04T17:57:22Z.

@srid
srid marked this pull request as ready for review May 4, 2026 18:24
@srid
srid merged commit 63dc40d into master May 4, 2026
16 of 17 checks passed
@srid
srid deleted the fix-820-inspector-shortcut branch May 4, 2026 18:27
srid added a commit that referenced this pull request May 15, 2026
`Ctrl+B` was released back to the terminal in #821, then reclaimed
as the dock toggle shortcut when the dock shipped as canonical in
#903. The unit test still asserted "does not capture Ctrl+B" — flip
to assert it matches, since `toggleDock` carries `{key:"b", mod:true}`
and `mod` resolves to `ctrlKey` on Linux/Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or change Ctrl+b (Linux) shortcut

1 participant