Skip to content

Minor refinements to options declaration #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
leomayleomay wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor refinements to options declaration #4

leomayleomay wants to merge 2 commits into from

Conversation

@leomayleomay
Copy link

@leomayleomay leomayleomay commented Jun 3, 2024 •
edited
Loading

  1. Use type alias featureType
  2. Fix the URL pointing to Just import

@leomayleomay
1. Use type alias featureType
75ef37f 
2. Fix the URL pointing to Just import
srid
srid reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@srid srid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But I'll have to test this before merging (ideally after #5).

@leomayleomay
Copy link
Author

leomayleomay commented Jun 4, 2024

@srid indeed, I've added CI

@leomayleomay leomayleomay requested a review from srid June 4, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srid srid Awaiting requested review from srid

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leomayleomay @srid