emscripten-4x wip #311
emscripten-4x wip #311
Conversation
| logger: this.logger | ||
| }); | ||
| // Load shared libs' | ||
| const is_emscripten_4x_or_higher = true; // fixme |
There was a problem hiding this comment.
Note for future, we may be able to detect the emscripten abi version in the env?
| } catch (e) { | ||
| console.log("kernelSpec.argv: ", kernelSpec.argv); | ||
| // try { | ||
| // this.xkernel = new this.Module.xkernel(kernelSpec.argv); |
There was a problem hiding this comment.
All kernels need to support beeing constructed from kernelSpec.argv because we cannot use the try-catch block with emscripten-4x.
One gets errrors about bindings for the kernels beeing registerd multiple times...
There was a problem hiding this comment.
cc. @anutosh491 for awareness.
I don't remember exactly the detail but we decided to have this try/catch for backward compat with some kernel that don't take argv.
There was a problem hiding this comment.
Ahh @DerThorsten ,
Yes we needed to pass the kernelSpec.argv because for xeus-cpp-lite. So that the kernels can respect the C++ versions passed from the kernel spec at runtime.
Check
jupyter-xeus/xeus-lite#16 in xeus-lite
and
Removed unused WebAssembly types and classes from worker.base.ts.
3 participants
No description provided.