Skip to content

Update to cockle 0.0.13 #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025
+8 −8
Merged

Update to cockle 0.0.13 #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18bb547
Update to cockle 0.0.13
ianthomas23 Jan 6, 2025
c8237e2
Fix update snapshot workflow
ianthomas23 Jan 6, 2025
7d90c26
Manually update snapshot images
ianthomas23 Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/update-integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1

- name: Install dependencies
run: python -m pip install -U "jupyterlab>=4.0.0,<5"
run: python -m pip install -U --pre "jupyterlite-core>=0.4,<0.5" "jupyterlab>=4,<5"

- name: Install extension
run: |
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@jupyterlab/services": "^7.2.4",
"@jupyterlab/terminal": "^4.2.4",
"@jupyterlab/terminal-extension": "^4.2.4",
"@jupyterlite/cockle": "^0.0.12",
"@jupyterlite/cockle": "^0.0.13",
"@jupyterlite/contents": "^0.4.0",
"@jupyterlite/server": "^0.4.0",
"@lumino/coreutils": "^2.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class Terminal implements ITerminal {
});
}

private async _outputCallback(text: string): Promise<void> {
private _outputCallback(text: string): void {
if (this._socket) {
const ret = JSON.stringify(['stdout', text]);
this._socket.send(ret);
Expand Down
Binary file modified ui-tests/tests/jupyterlite_terminal.spec.ts-snapshots/initial-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ui-tests/tests/jupyterlite_terminal.spec.ts-snapshots/various-commands-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2808,17 +2808,17 @@ __metadata:
languageName: node
linkType: hard

"@jupyterlite/cockle@npm:^0.0.12":
version: 0.0.12
resolution: "@jupyterlite/cockle@npm:0.0.12"
"@jupyterlite/cockle@npm:^0.0.13":
version: 0.0.13
resolution: "@jupyterlite/cockle@npm:0.0.13"
dependencies:
"@jupyterlite/contents": ^0.4.1
"@lumino/disposable": ^2.1.3
"@lumino/signaling": ^2.1.3
comlink: ^4.4.1
rimraf: ^6.0.1
zod: ^3.23.8
checksum: cc9ac8a20df828270085f89e2e031f941fadca5635e2aa247451a748eadf684146ebce8f748e88c5143bdbbc9bf52ab6d11bb1110fc3f8f32571810d6c03ed02
checksum: f3defe53f8798d6374abadfbc966138c6e42fa81260abac74f31ce3de956a7b216238bccc1b56fbb4aac1aec25b934026e2d4d793ee15124b6b3fd7e11cfe111
languageName: node
linkType: hard

Expand Down Expand Up @@ -2926,7 +2926,7 @@ __metadata:
"@jupyterlab/terminal": ^4.2.4
"@jupyterlab/terminal-extension": ^4.2.4
"@jupyterlab/testutils": ^4.2.4
"@jupyterlite/cockle": ^0.0.12
"@jupyterlite/cockle": ^0.0.13
"@jupyterlite/contents": ^0.4.0
"@jupyterlite/server": ^0.4.0
"@lumino/coreutils": ^2.2.0
Expand Down
Loading