-
Notifications
You must be signed in to change notification settings - Fork 29
Allow enabling/disabling REPL code execution in the Replite directive
#245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Carreau
merged 8 commits into
jupyterlite:main
from
agriyakhetarpal:feat/no-execute-replite-kernel
Jan 13, 2025
Merged
Allow enabling/disabling REPL code execution in the Replite directive
#245
Carreau
merged 8 commits into
jupyterlite:main
from
agriyakhetarpal:feat/no-execute-replite-kernel
Jan 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replite directive
Carreau
reviewed
Jan 6, 2025
jtpio
reviewed
Jan 9, 2025
Member
Author
|
Thanks for the reviews – rebasing and applying the suggested changes in a moment |
Co-authored-by: M Bussonnier <bussonniermatthias@gmail.com>
This reverts commit 1b3b20b.
Carreau
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request exposes functionality added upstream via jupyterlite/jupyterlite#1547 and released in
jupyterlite-coreversion0.5.0.In particular, this enables the act of enabling/disabling the code execution for the
Replitedirective, so it is now possible for the REPL not to load the Pyodide kernel automatically and instead wait for the user's input. It can be controlled via thereplite_auto_executeoption globally or via the:execute: [True/False]option on a per-directive basis as an override. This appends&execute=0to the REPL URL ifFalse.It is to be noted that while we support
jupyterlite-core >=0.2,<0.6via #238, this option requiresjupyterlite >= 0.5to work, and there is no effect for versions prior tojupyterlite-core0.5.Closes #244
Changes made
replite_auto_executeglobal configuration option, an:execute:option for the Replite directive, and corresponding URL handlingAdditional context
This will help us make progress on matplotlib/matplotlib#22634