Run pre-commit on all files in this repository. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should only reformat JS and css files. I've requested precommit-ci to be insalled on the JupyterLIght org, but do not have enough permission to allow it. One it is done and configured, it will automatically update PRs by autoformatting, so a first pass to autoformat everything is good to not have noise in later PRs.
Member
Should be good now:
|
Collaborator
Author
|
I'm going to merge and rebase my other PR to see if pre-commit triggers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only reformat JS and css files.
I've requested precommit-ci to be insalled on the JupyterLIght org, but do not have enough permission to allow it.
One it is done and configured, it will automatically update PRs by autoformatting, so a first pass to autoformat everything is good to not have noise in later PRs.