Skip to content

Conversation

@Carreau
Copy link
Collaborator

@Carreau Carreau commented Feb 13, 2024

The button appear next to the "Go back" button once a user has already shown the iframe.

@Carreau Carreau added the enhancement New feature or request label Feb 13, 2024
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you be able to add it to the jupyterlite-sphinx docs so we can test it here?

@Carreau
Copy link
Collaborator Author

Carreau commented Feb 13, 2024

yeah, this is just a draft I submitted before going to lunch, i should have marked it as such. i'll do that later, as well as document and tweak the css.

@Carreau Carreau changed the title Attempt add adding a full screen in tab button. Add a full screen "Open in tab" button Feb 13, 2024
@Carreau
Copy link
Collaborator Author

Carreau commented Feb 13, 2024

It works on RTD:
Screenshot 2024-02-13 at 16 34 44

and is also affected by custom CSS:

Screenshot 2024-02-13 at 16 36 04

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants