Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native iterators instead of Lumino iterators #346

Merged
merged 62 commits into from
Aug 17, 2022
Merged

Use native iterators instead of Lumino iterators #346

merged 62 commits into from
Aug 17, 2022

Commits on Aug 16, 2022

  1. Refactor some of the public API for iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    8639b66 View commit details
    Browse the repository at this point in the history

  2. More iterator refactoring

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a935f6a View commit details
    Browse the repository at this point in the history

  3. Update each<T>() function

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    029bcc3 View commit details
    Browse the repository at this point in the history

  4. Remove ArrayIterator<T>

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c88f20b View commit details
    Browse the repository at this point in the history

  5. Remove KeyIterator, ValueIterator<T>, ItemIterator<T>, and FnIterator<T>

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f5176d6 View commit details
    Browse the repository at this point in the history

  6. Remove zip<T>() and ZipIterator<T>

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    150738a View commit details
    Browse the repository at this point in the history

  7. Remove take<T>() and TakeIterator<T>

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ddeab32 View commit details
    Browse the repository at this point in the history

  8. Remove toArray<T>()

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ebc44cc View commit details
    Browse the repository at this point in the history

  9. Remove ChainIterator<T> and reimplement chain<T>() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d40cc10 View commit details
    Browse the repository at this point in the history

  10. Remove RepeatIterator<T> and reimplement repeat<T>() and once<T>() wi… 

    …th native iterators
    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    77a44ae View commit details
    Browse the repository at this point in the history

  11. Reimplement take<T>() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d1b6e2e View commit details
    Browse the repository at this point in the history

  12. Reimplment zip<T>() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    4c13c6f View commit details
    Browse the repository at this point in the history

  13. Reimplment stride<T>() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    588e666 View commit details
    Browse the repository at this point in the history

  14. Update topologicSort<T>() to accept native iterable

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    346cd2a View commit details
    Browse the repository at this point in the history

  15. Reimplment retro<T>() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    de3de59 View commit details
    Browse the repository at this point in the history

  16. Update reduce() to use native iterables

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    acaa6ed View commit details
    Browse the repository at this point in the history

  17. Reimplment range() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fb48177 View commit details
    Browse the repository at this point in the history

  18. Reimplement empty() with native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    e6964f3 View commit details
    Browse the repository at this point in the history

  19. Reimplement filter<T>() with native interators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    462f495 View commit details
    Browse the repository at this point in the history

  20. Reimplement map<T>() with native interators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    6abfc62 View commit details
    Browse the repository at this point in the history

  21. Update find(), findIndex(), min(), max(), and minmax() to use native … 

    …types
    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    298ac8c View commit details
    Browse the repository at this point in the history

  22. Reimplement enumerate() with native types

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9380340 View commit details
    Browse the repository at this point in the history

  23. Fix algorithm package tests

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ccbb647 View commit details
    Browse the repository at this point in the history

  24. Update LinkedList to use native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    518079c View commit details
    Browse the repository at this point in the history

  25. Fix LinkedList tests

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    481cfb7 View commit details
    Browse the repository at this point in the history

  26. Update disposable

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    82d9b28 View commit details
    Browse the repository at this point in the history

  27. Update widgets to use native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b4c1250 View commit details
    Browse the repository at this point in the history

  28. Fix widget tests

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3ab8cb1 View commit details
    Browse the repository at this point in the history

  29. Update data grid to use native iterators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    3d633c4 View commit details
    Browse the repository at this point in the history

  30. Update API report

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    4f1a5c1 View commit details
    Browse the repository at this point in the history

  31. Fix doc strings

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    797ea47 View commit details
    Browse the repository at this point in the history

  32. Minor tweak of LinkedList iterator methods

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fbc612a View commit details
    Browse the repository at this point in the history

  33. Simplify chain<T>()

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    720ce2e View commit details
    Browse the repository at this point in the history

  34. Simplify take<T>()

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    35d6f40 View commit details
    Browse the repository at this point in the history

  35. [Symbol.iterator]() and Array.from() should almost never need invoked

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    050daeb View commit details
    Browse the repository at this point in the history

  36. Third parameter for comparator functions is superfluous when they are… 

    … iterables
    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d6012a4 View commit details
    Browse the repository at this point in the history

  37. Simplify stride<T>()

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0f2ec49 View commit details
    Browse the repository at this point in the history

  38. Re-enable zip() tests

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    68eb1dd View commit details
    Browse the repository at this point in the history

  39. Simplify iterating through selections in data grid.

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    a5bc2c3 View commit details
    Browse the repository at this point in the history

  40. Tweak retro<T>() for readability

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f0189cc View commit details
    Browse the repository at this point in the history

  41. Use for...of for minmax<T>()

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    8a9574a View commit details
    Browse the repository at this point in the history

  42. Use IterableIterator as return type for all generators

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    fbf1317 View commit details
    Browse the repository at this point in the history

  43. Use for...of instead of each() in disposable and update generated API

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    654aef5 View commit details
    Browse the repository at this point in the history

  44. Use for...of instead of each() in LinkedList and topologicSort

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    14aa4da View commit details
    Browse the repository at this point in the history

  45. Use for...of instead of each in signaling

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    eba5225 View commit details
    Browse the repository at this point in the history

  46. Use for...of instead of each() in messaging

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    688cb0f View commit details
    Browse the repository at this point in the history

  47. In almost all cases, prefer native for..of or .forEach to Lumino util… 

    …ities
    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    ad8e19b View commit details
    Browse the repository at this point in the history

  48. Fix examples

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    00e6855 View commit details
    Browse the repository at this point in the history

  49. Fine.

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b9a0b1b View commit details
    Browse the repository at this point in the history

  50. Add iteration notes to migration.md

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0f747de View commit details
    Browse the repository at this point in the history

  51. Add test for take() where count=0

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    9caca56 View commit details
    Browse the repository at this point in the history

  52. Remove duplicate repeat() test

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d74f6c2 View commit details
    Browse the repository at this point in the history

  53. Better label for stride() test

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    929b6d9 View commit details
    Browse the repository at this point in the history

  54. Better labels for zip() tests

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1fbfcae View commit details
    Browse the repository at this point in the history

  55. Clean up test labels as per review comments

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    bc2b48f View commit details
    Browse the repository at this point in the history

  56. Change rangeLength signature back

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    84ec11b View commit details
    Browse the repository at this point in the history

  57. Reimplement toObject() using iterables and toArray() as a deprecated … 

    …placeholder for Array.from()
    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1442576 View commit details
    Browse the repository at this point in the history

  58. Better toObject() test

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    da91b28 View commit details
    Browse the repository at this point in the history

  59. Fix logic bug in take() that @vidartf noticed

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    c6673e8 View commit details
    Browse the repository at this point in the history

  60. Fix typo

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    071756a View commit details
    Browse the repository at this point in the history

  61. Another .forEach() => for...of

    @afshin
    afshin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    1197d76 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Update packages/algorithm/src/iter.ts 

    Co-authored-by: Vidar Tonaas Fauske <vidartf@gmail.com>
    @afshin @vidartf
    afshin and vidartf authored Aug 17, 2022
    Configuration menu
    Copy the full SHA
    c340bd6 View commit details
    Browse the repository at this point in the history