Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumino 2 - meta PR with multiple items resolved #319

Merged
merged 24 commits into from
Aug 1, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Jul 26, 2022

@afshin afshin added bug Something isn't working enhancement New feature or request labels Jul 26, 2022
@afshin afshin added this to the Lumino 2 milestone Jul 26, 2022
@afshin afshin self-assigned this Jul 26, 2022
@afshin afshin mentioned this pull request Jul 26, 2022
16 tasks
@afshin afshin changed the title Update TypeScript to 4.x Lumino 2 Jul 26, 2022
@afshin afshin changed the title Lumino 2 Lumino 2 update TypeScript dependencies Jul 26, 2022
@afshin afshin changed the title Lumino 2 update TypeScript dependencies Lumino 2: update TypeScript dependencies Jul 26, 2022
@bollwyvl
Copy link
Contributor

bollwyvl commented Jul 26, 2022

It would be lovely if command schema happened in 2.

edit: see it's in the plan on #233 😊

The quesiton remains whether it ships with a validator.

@afshin afshin force-pushed the lumino-2 branch 2 times, most recently from d9de518 to d73144b Compare July 26, 2022 20:46
@fcollonval fcollonval changed the title Lumino 2: update TypeScript dependencies Lumino 2 - meta PR with multiple items resolved Jul 27, 2022
@afshin afshin marked this pull request as ready for review July 29, 2022 13:02
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this big clean up @afshin

I have minor questions but the new code is looking good.

package.json Outdated Show resolved Hide resolved
packages/algorithm/src/reduce.ts Show resolved Hide resolved
packages/commands/src/index.ts Outdated Show resolved Hide resolved
packages/coreutils/src/mime.ts Show resolved Hide resolved
packages/coreutils/src/token.ts Show resolved Hide resolved
packages/datagrid/src/celleditor.ts Outdated Show resolved Hide resolved
afshin and others added 2 commits July 29, 2022 20:09
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
@afshin
Copy link
Member Author

afshin commented Jul 29, 2022

Even though the RTD job doesn't fail, the rendered output actually looks broken.

I'm not sure how to fix it, but let's not merge this until the docs work.

@afshin
Copy link
Member Author

afshin commented Aug 1, 2022

I will stop adding to this PR because there's still plenty left to do and it will just get bigger and bigger. I added #325 to denote that the dependency updates are not yet finished.

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afshin

Let's merge this one.

@afshin afshin merged commit bbc29cf into jupyterlab:main Aug 1, 2022
@afshin
Copy link
Member Author

afshin commented Aug 5, 2022

Fixes #106

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants