-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lumino 2 - meta PR with multiple items resolved #319
Conversation
It would be lovely if command schema happened in 2. edit: see it's in the plan on #233 😊 The quesiton remains whether it ships with a validator. |
d9de518
to
d73144b
Compare
Co-authored-by: Naveen Michaud-Agrawal <naveen.michaudagrawal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this big clean up @afshin
I have minor questions but the new code is looking good.
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
Even though the RTD job doesn't fail, the rendered output actually looks broken. I'm not sure how to fix it, but let's not merge this until the docs work. |
I will stop adding to this PR because there's still plenty left to do and it will just get bigger and bigger. I added #325 to denote that the dependency updates are not yet finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @afshin
Let's merge this one.
Fixes #106 |
GlobalCompositeOperation
error in data grid package #298icon
APIs@lumino/dragdrop
and@lumino/widgets
in favor of pointer eventses6-promise
polyfillsimulate-event
from the dependencies and uses nativedispatchEvent
andEvent
,FocusEvent
,KeyboardEvent
,MouseEvent
, andPointerEvent
eslint
issues that show up in GitHubcrypto
dependency in@lumino/coreutils
because Node ships with acrypto
module in its standard library