Support Windows Paths

[dhirschfeld]

...as often (almost always) it won't fit and the most important part, the filename itself, is currently being truncated:

[dhirschfeld]

I think the PyCharm UI here is the ideal to strive towards. In PyCharm only the filename is displayed, unless there is another tab with the same name open in which case parent folders are shown until the tabs are uniquely identified.

e.g. for the folders shown below only the filename and parent folder are shown as those are sufficient to uniquely identify the file:

/scripts/test/run.py
/scripts/data/export/run.py

The key aspect for me is the most important information is chosen to be displayed - the least important information is the root of the filesystem as it is common to everything.

[jasongrout]

Interesting. The path doesn't show for me, just the filename (firefox, macOS):

What version of JupyterLab do you have? What browser? From the path it seems you are on Windows?

[dhirschfeld]

I'm running 33.4 on win64, chrome 67.0.3396.99

Edit: Also seeing this in Firefox Developer 62.0b11

[dhirschfeld]

Ok, confirmed that this happens when you use Open from Path to open a file rather than the FileBrowser:

[blink1073]

Hi @dhirschfeld, two questions:

• Where did you launch jupyterlab from?
• How did you enter the path in the Open from Path dialog?

I wasn't able to repro on Win 10 in Chrome 68.

[dhirschfeld]

JupyterLab is launched with jupyter labhub ... from JupyterHub. JupyterLab itself is running in a Windows Container. The full path name C:\Miniconda3\lib\base64.py was pasted in the Open from Path dialog.

I can do some further testing when I'm back from holiday in a weeks time...

[blink1073]

Thanks, enjoy!

[blink1073]

I'm confused as to how pasting the full file path opened anything. The open file path is supposed to take a server path, with starts with / at the server root directory.

[dhirschfeld]

I'll double check that. Was just quoting from memory. I'm sure I copied the path from an exception to open the file. That's a very useful capability to have IMHO which is why I start my server in C:\ - prob why it worked?

[blink1073]

What I tried locally was launching from C: and trying to open C:/Users/<user>/Untitled.ipynb, and I got a file not found error.

[blink1073]

Jupyter does not map directly to file system paths on purpose, because your "file system" could be a remote database. I'm not sure how I feel about allowing raw paths like that in general...