Change default value for cleanup to False in latex_cleanup

[cmarmo]

Dear maintainers,

I'm planning to use this extension in production together with jupyterlab-git.
In this pull request I'm suggesting to change the default value of cleanup in the latex_cleanup context manager to False: I believe this is a safer default solution (see #158, #124).

Thank you for considering it.

[github-actions]

👈 Launch a Binder on branch cmarmo/jupyterlab-latex/cleanup-false

[krassowski]

Does it work? It would seem this default is not used in:

jupyterlab-latex/jupyterlab_latex/build.py

Lines 306 to 307 in db3dd9b

	with latex_cleanup(
	cleanup=c.cleanup,

Can it be changed on the trait level?

jupyterlab-latex/jupyterlab_latex/config.py

Lines 29 to 30 in 58abc9c

	cleanup = Bool(default_value=True, config=True,
	help='Whether to clean up ".out/.aux" files or not.')

[krassowski]

Also I guess the help message should clarify that it is more aggressive than just out/aux

[cmarmo]

Does it work? It would seem this default is not used in:

Right! Sorry I didn't catch how it's working.
I have modified config.py and clarified (I hope) the documentation.
Thanks for your review!

[krassowski]

It fell through the cracks but it looks good to me - thank you!