Skip to content

jupyterlab-git incorrectly responds to filebowser events of other extensions #1014

@jhgoebbert

Description

@jhgoebbert

When using a JupyterLab extension like jupyterlab-gitlab (https://gitlab.com/beenje/jupyterlab-gitlab/-/tree/jupyterlab-3)
which inherits from the JupyterLab file browser class,
then jupyterlab-git seems to be mistakenly notified of that file browser events.

Output from webbrowser's console:

Fail to find Git top level for path GitLab:jupyter4jsc/j4j_notebooks.
Error: Traceback (most recent call last):
  File "/lib/python3.8/site-packages/jupyterlab_git/git.py", line 144, in execute
    code, output, error = await current_loop.run_in_executor(
  File "/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/lib/python3.8/site-packages/jupyterlab_git/git.py", line 110, in call_subprocess
    process = subprocess.Popen(
  File "/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/home/goebbert1/gitlab:/jupyter4jsc/j4j_notebooks'

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions