Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of traitlets to configure YStore class #322

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix use of traitlets to configure YStore class #322

merged 2 commits into from
Jul 9, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski added the bug Something isn't working label Jul 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Binder 👈 Launch a Binder on branch krassowski/jupyter_collaboration/fix-traitlet-use-for-YStore

@krassowski krassowski force-pushed the fix-traitlet-use-for-YStore branch from 2ffeec8 to 5bb041f Compare July 9, 2024 12:49
@krassowski
Copy link
Member Author

krassowski commented Jul 9, 2024 •
edited
Loading

I believe the failures on Windows are unrelated, marking as ready for review.

@krassowski krassowski marked this pull request as ready for review July 9, 2024 13:37
@krassowski krassowski mentioned this pull request Jul 9, 2024
Closed
@davidbrochart
Copy link
Collaborator

I believe the failures on Windows are unrelated, marking as ready for review.

Yes, failures are due to jupyter-server/jupyter_server_fileid#75.

davidbrochart
davidbrochart approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @krassowski.

@davidbrochart davidbrochart merged commit 4f3fdfd into jupyterlab:main Jul 9, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time-to-live support not working anymore?
2 participants
@krassowski @davidbrochart