Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix writing settings in page_config #304

Merged
merged 1 commit into from
May 7, 2024
Merged

Fix writing settings in page_config #304

merged 1 commit into from
May 7, 2024

Conversation

fcollonval
Copy link
Member

The current code does not write the extension settings in the page config as page_config_data already exists.

@fcollonval fcollonval added the bug Something isn't working label May 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024

Binder 👈 Launch a Binder on branch jupyterlab/jupyter-collaboration/fcollonval-patch-1

davidbrochart
davidbrochart approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval.
Failures are unrelated, I opened #305.

@fcollonval fcollonval merged commit ecc0028 into main May 7, 2024
12 of 22 checks passed
@davidbrochart davidbrochart deleted the fcollonval-patch-1 branch May 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbrochart davidbrochart davidbrochart approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @davidbrochart