Fix UI tests #277
Merged
Fix UI tests #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix lockfile
(it is not!); because in lab 4.1 the DOM hierarchy changed (toolbar is now using shadow DOM), instead select the things which are of interest using precise selectors
|
|
davidbrochart
approved these changes
Apr 1, 2024
krassowski
added a commit
to krassowski/jupyter_collaboration
that referenced
this pull request
Apr 11, 2024
* Upgrade galata to lab 4.1 Fix lockfile * Use `jp-button` instead of button * Be more explicit with test checking for "user menu with 2 items" (it is not!); because in lab 4.1 the DOM hierarchy changed (toolbar is now using shadow DOM), instead select the things which are of interest using precise selectors * Update snapshots * Update two more snapshots, switch serial assertions to soft * Fix `Create a notebook` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #276