Fix slow room opening #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I just added a test, that currently fails. |
|
The test now passes (it fails at teardown due to |
|
Oh nice! (I think) I observed this issue too, but wasn't able to reproduce it reliably, so I wasn't able to create a bug report. |
Zsailer
approved these changes
Mar 27, 2024
trungleduc
approved these changes
Mar 27, 2024
|
Thanks @davidbrochart for the quick reaction! |
jzhang20133
approved these changes
Mar 27, 2024
andrii-i
pushed a commit
to andrii-i/jupyter-collaboration
that referenced
this pull request
Feb 11, 2025
* Fix slow room opening * Add fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263.
cc @trungleduc