Skip to content

Commit

Permalink
Backport #172 on branch 1.x (Remove print) (#188)
Browse files Browse the repository at this point in the history
* Backport #172 on branch 1.x (Remove print)

* Backport part of #186 on branch 1.x (Bump jupyter_events and jsonschema)

---------

Co-authored-by: Carlos Herrero <26092748+hbcarlos@users.noreply.github.com>
  • Loading branch information
fcollonval and hbcarlos authored Sep 5, 2023
1 parent 025a248 commit 70c771c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install dependencies
run: |
pip install jupyterlab
Expand Down Expand Up @@ -49,6 +51,8 @@ jobs:
uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.11'
- name: Install dependencies
run: |
pip install jupyterlab
Expand Down
1 change: 0 additions & 1 deletion jupyter_collaboration/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ def on_message(self, message):
On message receive.
"""
message_type = message[0]
print("message type:", message_type)

if message_type == YMessageType.AWARENESS:
# awareness
Expand Down
6 changes: 3 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ dependencies = [
"jupyter_server>=2.0.0,<3.0.0",
"jupyter_ydoc>=1.0.1,<2.0.0",
"ypy-websocket>=0.12.1,<0.13.0",
"jupyter_events",
"jupyter_server_fileid>=0.6.0,<1",
"jsonschema[format-nongpl,format_nongpl]<4.18.0" # https://github.com/jupyter/jupyter_events/pull/80
"jupyter_events>=0.7.0",
"jupyter_server_fileid>=0.7.0,<1",
"jsonschema>=4.18.0"
]
dynamic = ["version", "description", "authors", "urls", "keywords"]

Expand Down

0 comments on commit 70c771c

Please sign in to comment.