Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send with selection #82

Merged
merged 17 commits into from
Sep 23, 2024
Merged

Send with selection #82

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fa1065a
Rename addMessage to sendMessage in the chat model, for concistency
brichet Sep 16, 2024
7c11ed8
Add the selection watcher object, and modify the send button to allow…
brichet Sep 16, 2024
5048a02
Add the selection watcher to the collaborative chat (work only with t…
brichet Sep 16, 2024
cf6a512
Add a selection watcher to the websocket chat
brichet Sep 16, 2024
baa2e03
Automatic application of license header
github-actions[bot] Sep 16, 2024
51c76d1
Change the state of include button on signal
brichet Sep 17, 2024
0a84e04
Hide the 'include selection' menu when editing a message or if the to…
brichet Sep 17, 2024
9503967
Invert the logic to hide the 'include selection' menu
brichet Sep 17, 2024
fe3bf9d
Adopt the same button style for the cancel button
brichet Sep 17, 2024
c76824f
Automatic application of license header
github-actions[bot] Sep 17, 2024
aff7c23
Handle the selected text if the chat is a main area widget
brichet Sep 17, 2024
b726d09
Add the ability to replace the current selection on visible editor
brichet Sep 17, 2024
c1fb648
Fixes ui-tests
brichet Sep 18, 2024
2e94e31
lint
brichet Sep 18, 2024
491a751
Fix the selection watcher for a new notebook file
brichet Sep 19, 2024
b3a093e
Add tests
brichet Sep 19, 2024
81e631e
update snapshots
brichet Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@brichet
brichet committed Sep 19, 2024
commit 2e94e31d1177ecfce0c1ad8a1b4fd9fc34f5de59
5 changes: 3 additions & 2 deletions python/jupyterlab-collaborative-chat/ui-tests/tests/jupyterlab_collaborative_chat.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,9 @@ test.describe('#sendMessages', () => {
const input = chatPanel
.locator('.jp-chat-input-container')
.getByRole('combobox');
const sendButton = chatPanel
.locator('.jp-chat-input-container .jp-chat-send-button');
const sendButton = chatPanel.locator(
'.jp-chat-input-container .jp-chat-send-button'
);
await input.pressSequentially(MSG_CONTENT);
await sendButton.click();

Expand Down
5 changes: 3 additions & 2 deletions python/jupyterlab-collaborative-chat/ui-tests/tests/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@ export const sendMessage = async (
const input = chatPanel
.locator('.jp-chat-input-container')
.getByRole('combobox');
const sendButton = chatPanel
.locator('.jp-chat-input-container .jp-chat-send-button');
const sendButton = chatPanel.locator(
'.jp-chat-input-container .jp-chat-send-button'
);
await input.pressSequentially(content);
await sendButton.click();
};