-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Generative AI' submenu #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the code and it looks great! Awesome PR.
One small note: For the ModuleNotFoundError
the fix action is not available. Not sure we want to be that inclusive as it is not a typical error. See:
It could add a line of code to install the missing module if fix was possible. See that it works with `/fix' in chat as intended:
Great idea to add it to the right-click menu because the Gen AI submenu can be used to add more functionality as needed in addition to the four actions currently included.
@srdas One weird caveat is that to fix/explain/optimize/refactor a cell, you have to left-click on the cell first to make it the active cell, and then right-click to select the AI task you want to perform. Right-clicking on a cell does not make it the active cell in JupyterLab. This is existing behavior that is also shown by the other context menu options. See the demo video below, where I right click on a cell that is not the active cell, then click delete. Notice that the cell I right-clicked on is not deleted. Screen.Recording.2024-08-29.at.1.06.41.PM.mov |
@dlqqq Thanks, I retested it and it is working correctly after the left-click + right-click. Perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good
Description
/fix
, and only works when a code cell with an error output is selected as the active cell.{Explain,Optimize,Refactor} the code below
.Demo
Screen.Recording.2024-08-29.at.8.06.48.AM.mov
Future work