Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework selection inclusion; new Send button UX #905

Merged
merged 13 commits into from
Jul 29, 2024
Merged

Rework selection inclusion; new Send button UX #905

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
1974856
remove include selection checkbox
dlqqq Jul 18, 2024
13e1db2
add new selection types to backend
dlqqq Jul 22, 2024
c26f2f1
add new TooltippedButton component
dlqqq Jul 22, 2024
efe2522
add `prompt` field to `HumanChatMessage`
dlqqq Jul 22, 2024
1767b6c
add new include selection icon
dlqqq Jul 23, 2024
a23f9fa
implement new send button
dlqqq Jul 23, 2024
fcbea3d
pre-commit
dlqqq Jul 23, 2024
5788078
fix unit tests
dlqqq Jul 23, 2024
0aef75e
pre-commit
dlqqq Jul 23, 2024
a0e2b67
edit cell selection tooltip to indicate output is not included
dlqqq Jul 29, 2024
0d4e355
allow Enter to open dropdown menu
dlqqq Jul 29, 2024
806940c
fix double-send bug when using keyboard
dlqqq Jul 29, 2024
b678b66
re-enable auto focus for first item
dlqqq Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix double-send bug when using keyboard
  • Loading branch information
@dlqqq
dlqqq committed Jul 29, 2024
commit 806940cb0bcc35b51d0126f3ff91f7a2b292334e
6 changes: 5 additions & 1 deletion packages/jupyter-ai/src/components/chat-input/send-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ export function SendButton(props: SendButtonProps): JSX.Element {
}}
>
<MenuItem
onClick={() => sendWithSelection()}
onClick={e => {
sendWithSelection();
// prevent sending second message with no selection
e.stopPropagation();
}}
disabled={includeSelectionDisabled}
>
<includeSelectionIcon.react />
Expand Down