Updated Hugging Face chat and magics processing with new APIs, clients #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) The API has changed and uses the HuggingFaceClient class instead of HuggingFaceHub, which is deprecated. (2) InferenceClient replaces InferenceAPI (3) Removed legacy code that does not work with the new APIs/
for more information, see https://pre-commit.ci
dlqqq
requested changes
May 15, 2024
There was a problem hiding this comment.
Left a comment below, but didn't complete a full review.
We should try to preserve the image generation capability when this provider is used in magics. Dropping that feature, although minor, would constitute a breaking change. I'm looking into the options available to us to support this.
Added logic to branch to one of text-gen or text-to-image tasks based on the type of response received.
for more information, see https://pre-commit.ci
srdas
changed the title
JasonWeill
approved these changes
May 16, 2024
dlqqq
requested changes
May 16, 2024
Used a different approach to check for task type
…into change_HF_client
for more information, see https://pre-commit.ci
dlqqq
approved these changes
May 16, 2024
|
Note: this PR will not be backported to 1.x as JupyterLab 3 reached end-of-maintenance yesterday. See #761. |
This was referenced May 22, 2024
krassowski
added a commit
to krassowski/jupyter-ai
that referenced
this pull request
Jul 12, 2024
the overridden method is no longer overriding allowed task list since jupyterlab#784 but is only breaking streaming - it can be removed
dlqqq
pushed a commit
to krassowski/jupyter-ai
that referenced
this pull request
Jul 12, 2024
the overridden method is no longer overriding allowed task list since jupyterlab#784 but is only breaking streaming - it can be removed
dlqqq
pushed a commit
that referenced
this pull request
Jul 12, 2024
the overridden method is no longer overriding allowed task list since #784 but is only breaking streaming - it can be removed
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
jupyterlab#784) * Updated HF chat processing (1) The API has changed and uses the HuggingFaceClient class instead of HuggingFaceHub, which is deprecated. (2) InferenceClient replaces InferenceAPI (3) Removed legacy code that does not work with the new APIs/ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Handle text gen and text_to_image tasks Added logic to branch to one of text-gen or text-to-image tasks based on the type of response received. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Reworking conditional branching for text vs image Used a different approach to check for task type * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
the overridden method is no longer overriding allowed task list since jupyterlab#784 but is only breaking streaming - it can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
(1) The API has changed and uses the
HuggingFaceEndpointclass instead ofHuggingFaceHub, which is deprecated.(2)
InferenceClientreplacesInferenceAPI(3) Removed legacy code that does not work with the new APIs
(4) Added logic to detect the
taskfrom the response type and handle text or images as needed.References to the new
langchainsource for the new classes and APIs:Test Example:
Use the
mistralmodelChat question: