Skip to content

Fix /learn in 2.14.0 #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fix /learn in 2.14.0 #747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff55f3d
accumulate filepaths
michaelchia Apr 26, 2024
ba2c364
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/jupyter-ai/jupyter_ai/document_loaders/directory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ def split(path, all_files: bool, splitter):

# Check if the path points to a single file
if os.path.isfile(path):
dir = os.path.dirname(path)
filenames = [os.path.basename(path)]
filepaths = [Path(path)]
else:
filepaths = []
for dir, subdirs, filenames in os.walk(path):
# Filter out hidden filenames, hidden directories, and excluded directories,
# unless "all files" are requested
Expand All @@ -77,9 +77,9 @@ def split(path, all_files: bool, splitter):
d for d in subdirs if not (d[0] == "." or d in EXCLUDE_DIRS)
]
filenames = [f for f in filenames if not f[0] == "."]
filepaths += [Path(os.path.join(dir, filename)) for filename in filenames]

for filename in filenames:
filepath = Path(os.path.join(dir, filename))
for filepath in filepaths:
# Lower case everything to make sure file extension comparisons are not case sensitive
if filepath.suffix.lower() not in {j.lower() for j in SUPPORTED_EXTS}:
continue
Expand Down