Upgraded LangChain, fixed prompts for Bedrock #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
force-pushed
the
fix-bedrock-support
branch
from
b02e1d2 to
4e3bcec
Compare
3coins
added
bug
3coins
force-pushed
the
fix-bedrock-support
branch
from
943c843 to
7ab465b
Compare
Collaborator
Author
|
Moving this to draft, will wait for this PR from LangChain to be merged. |
dlqqq
requested changes
Oct 4, 2023
3coins
force-pushed
the
fix-bedrock-support
branch
from
6186ecd to
f8a0ab2
Compare
dlqqq
approved these changes
Oct 5, 2023
Member
dlqqq
left a comment
dlqqq
left a comment
There was a problem hiding this comment.
Looks great! Thanks for working on Bedrock support so promptly. In the future, I think we definitely need to revisit DefaultChatHandler.create_llm_chain() and see if we can simplify the way we are building the complete prompt template.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399.