Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SageMaker Studio support #192

Merged
merged 4 commits into from
May 26, 2023
Merged

SageMaker Studio support #192

merged 4 commits into from
May 26, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented May 25, 2023 •
edited
Loading

Fixes #187
Fixes #194

@3coins 3coins added the bug Something isn't working label May 25, 2023
@dlqqq dlqqq changed the title Fix sm studio errors SageMaker Studio support May 25, 2023
@dlqqq
Copy link
Member

dlqqq commented May 25, 2023

Pushed a commit to fix the Typography styles in dark mode. It relies on an undocumented property typography.allVariants in the theme object. For some reason, palette.text sets the colors for all text except the main text component Typography. palette.text itself mostly undocumented, as it only shows up in the default theme with no accompanying docs. 🤦

@3coins
Copy link
Collaborator Author

3coins commented May 26, 2023

@dlqqq
Once the CI goes green, I would like to merge this. Let me know if we can do a release after the merge.

@3coins 3coins marked this pull request as ready for review May 26, 2023 02:08
@3coins
Copy link
Collaborator Author

3coins commented May 26, 2023

@dlqqq
Found another issue with magics. But this one might be related to remote kernels, not specifically anything in Jupyter AI.
#195

dlqqq
dlqqq approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome work @3coins.

@dlqqq dlqqq merged commit 241f58a into jupyterlab:main May 26, 2023
This was referenced May 30, 2023
Closed
Closed
@3coins 3coins deleted the fix-sm-studio-errors branch June 9, 2023 03:22
dlqqq added a commit to dlqqq/jupyter-ai that referenced this pull request Jan 11, 2024
@dlqqq
remove theme hack added in jupyterlab#192
831b07b
@dlqqq dlqqq mentioned this pull request Jan 11, 2024
Merged
dlqqq added a commit to garsonbyte/jupyter-ai that referenced this pull request Jan 23, 2024
@dlqqq
remove theme hack added in jupyterlab#192
c14d819
dlqqq added a commit that referenced this pull request Jan 23, 2024
@garsonbyte @dlqqq
Reflect theme changes without a refresh (#575)
ca03e2c 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in #192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
dlqqq pushed a commit to dlqqq/jupyter-ai that referenced this pull request Jan 23, 2024
@garsonbyte @dlqqq
Reflect theme changes without a refresh (jupyterlab#575)
6af68a5 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in jupyterlab#192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
(cherry picked from commit ca03e2c)
dlqqq pushed a commit to dlqqq/jupyter-ai that referenced this pull request Jan 23, 2024
@garsonbyte @dlqqq
Backport PR jupyterlab#575: Reflect theme changes without a refresh
ddc2095 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in jupyterlab#192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
(cherry picked from commit ca03e2c)
dlqqq added a commit that referenced this pull request Jan 23, 2024
@dlqqq @garsonbyte
Backport PR #575: Reflect theme changes without a refresh (#599)
f83b576 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in #192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
(cherry picked from commit ca03e2c)

Co-authored-by: Garson R Chow <58149459+garsonbyte@users.noreply.github.com>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@3coins @dlqqq
SageMaker Studio support (jupyterlab#192)
001112e 
* Upgraded langchain, pinned typing_extensions version

* Updated to return local host username for non-collaborative mode

* fix typography styles in dark mode

* Fixed /clear command

---------

Co-authored-by: David L. Qiu <david@qiu.dev>
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@garsonbyte @dlqqq
Reflect theme changes without a refresh (jupyterlab#575)
b205410 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in jupyterlab#192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@3coins @dlqqq @Marchlak
SageMaker Studio support (jupyterlab#192)
3ec3c82 
* Upgraded langchain, pinned typing_extensions version

* Updated to return local host username for non-collaborative mode

* fix typography styles in dark mode

* Fixed /clear command

---------

Co-authored-by: David L. Qiu <david@qiu.dev>
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
@garsonbyte @dlqqq @Marchlak
Reflect theme changes without a refresh (jupyterlab#575)
7f3e49d 
* Reflect theme changes without a refresh

By leveraging `IThemeManager.themeChanged`, we can listen on theme change signals
and rebuild the theme object in response. This allows CSS variable changes to reflect
in the MUI theme without having to refresh the page.

* update yarn.lock

* pass themeManager as a prop instead of using top-level scope

* remove theme hack added in jupyterlab#192

---------

Co-authored-by: gchow <garson.chow@factset.com>
Co-authored-by: David L. Qiu <david@qiu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/clear command does not delete /learn and /ask messages Fix Errors in SageMaker Studio
2 participants
@3coins @dlqqq