Changes chat messages to use absolute timestamps #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonWeill
force-pushed
the
chat-absolute-time
branch
from
afd6b04
to
3a9a185
Compare
andrii-i
reviewed
May 16, 2023
|
Let's fix CI or understand why it is failing before merging |
JasonWeill
force-pushed
the
chat-absolute-time
branch
from
093e3d8
to
3f0d16e
Compare
dlqqq
requested changes
May 17, 2023
|
Updated per @dlqqq's feedback |
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Changes messages to use absolute timestamps * Only calls setTimestamps if a new timestamp is added * Unwraps function * Prepopulates newTimestamps
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Changes messages to use absolute timestamps * Only calls setTimestamps if a new timestamp is added * Unwraps function * Prepopulates newTimestamps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87.
Instead of relative time (X minutes ago), displays messages using 12-hour or 24-hour time, based on the user's locale. Message timestamps are only computed once, not repeatedly every 5 seconds.