Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable inspector widget buttons visibility and delete functionality #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Darshan808
Copy link

Summary:

  • Made the delete and inspect content buttons visible by adjusting CSS (display: center) and replaced inappropriate icons:

    • Search icon replaced with an inspector icon.
    • Remove icon replaced with a delete icon for better clarity.
  • Enhanced the delete functionality:

    • Previously, the delete button only removed variables from the table but not from the kernel, causing them to reappear on re-inspection.
    • Now, variables are fully removed from both the table and the kernel upon deletion.
  • Addressed an inspection failure for lists and NumPy arrays:

    • When not using pandas, inspecting lists and NumPy arrays would fail due to pandas dependencies.
    • Added an alert message to notify users to import necessary modules if inspection fails, guiding them to resolve the issue.

Changes except kernel deletion functionality can be viewed in this SnapShot

Before: Unclear Buttons and unaddressed error

image

After: Clear Buttons and resolved error

Screenshot from 2024-10-19 17-24-39

Please let me know if further enhancement is required on this.

Copy link

Binder 👈 Launch a Binder on branch Darshan808/jupyterlab-variableInspector/fix-variable-inspector-buttons-and-kernel-deletion

@Darshan808
Copy link
Author

Darshan808 commented Oct 19, 2024

@krassowski @fcollonval
Could you please review this ? Is the import missing alert shown above a good approach?
Also I've been working on adding and editing variable functionality and could use some guidance. Should I implement the edit feature similar to how shortcuts are edited in settings, using an input box in place of variable's value? However, this might not be ideal for large matrices. Should I make the inspect content table editable for matrices instead? What would be the best way to proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant