Keep track of the last fragment or sub-slide displayed when moving back or forward #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brichet
force-pushed
the
back_forward_redirection
branch
from
18d1c3d to
8470e3e
Compare
brichet
force-pushed
the
back_forward_redirection
branch
from
8470e3e to
15d6c0c
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially opened at deathbeds/jupyterlab-deck#65
Checklist
doit lintlocallyReferences
deathbeds/jupyterlab-deck#49
Code changes
Adds a
redirectattribute to slide extent.This new attribute is filled with the index of the last fragment or subslide displayed in this "slide group".
It is used when falling back on a slide with left/right arrows.
User-facing changes
Using left/right arrows does not necessarily fall back on a
Slidetype anymore, but on the latest fragment of that slide.Backwards-incompatible changes
None