Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive this repository #60

Closed
wants to merge 2 commits into from
Closed

Archive this repository #60

wants to merge 2 commits into from

Conversation

fcollonval
Copy link
Member

No description provided.

@fcollonval fcollonval changed the title Update README.md Archive this repository Jun 5, 2023
@@ -1,3 +1,5 @@
:warning: **This repository is now archived as the feature is directly available when installing [`jupyter-collaboration`](https://github.com/jupyterlab/jupyter_collaboration)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the repo was renamed to use a - instead of _:

Suggested change
:warning: **This repository is now archived as the feature is directly available when installing [`jupyter-collaboration`](https://github.com/jupyterlab/jupyter_collaboration)**
:warning: **This repository is now archived as the feature is directly available when installing [`jupyter-collaboration`](https://github.com/jupyterlab/jupyter-collaboration)**

@jtpio
Copy link
Member

jtpio commented Jun 21, 2023

Thanks @fcollonval.

Pinging @yuvipanda and @minrk who also contributed to this repo, to make sure archiving it is fine with them too.

@minrk
Copy link
Contributor

minrk commented Jun 21, 2023

Does jupyter-collaboration address #54? jupyter-collaboration also explicitly recommends installing this extension in its docs. And does it still work to use collaboration to generate links with tokens when RTC is unavailable? If not, it doesn't really seem to replace this extension at all.

@fcollonval
Copy link
Member Author

fcollonval commented Jun 21, 2023

Does jupyter-collaboration address #54?

image

The dialog has a checkbox that you introduced to include or not the token. But I guess there is still the need to add a server settings for admin to control that behavior.

jupyter-collaboration also explicitly recommends installing this extension in its docs.

Thanks I opened a PR to remove it

And does it still work to use collaboration to generate links with tokens when RTC is unavailable? If not, it doesn't really seem to replace this extension at all.

This indeed is a good point for not archiving the repository.

@fcollonval
Copy link
Member Author

Closing this as per the discussion conclusion.

@fcollonval fcollonval closed this Aug 8, 2023
@fcollonval fcollonval deleted the fcollonval-patch-1 branch August 8, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants